Assign and initialize Spree::Config earlier, before rails initializers #2178
Conversation
| if !value || | ||
| value == 0 || | ||
| value =~ /\A(f|false|0)\Z/i || | ||
| (value.respond_to?(:empty?) && value.empty?) |
There was a problem hiding this comment.
Align the operands of a condition in an if statement spanning multiple lines.
| when :boolean | ||
| if !value || | ||
| value == 0 || | ||
| value =~ /\A(f|false|0)\Z/i || |
There was a problem hiding this comment.
Align the operands of a condition in an if statement spanning multiple lines.
| value.to_i | ||
| when :boolean | ||
| if !value || | ||
| value == 0 || |
There was a problem hiding this comment.
Align the operands of a condition in an if statement spanning multiple lines.
Use value.zero? instead of value == 0.
| if !value || | ||
| value == 0 || | ||
| value =~ /\A(f|false|0)\Z/i || | ||
| (value.respond_to?(:empty?) && value.empty?) |
There was a problem hiding this comment.
Align the operands of a condition in an if statement spanning multiple lines.
| when :boolean | ||
| if !value || | ||
| value == 0 || | ||
| value =~ /\A(f|false|0)\Z/i || |
There was a problem hiding this comment.
Align the operands of a condition in an if statement spanning multiple lines.
| value.to_i | ||
| when :boolean | ||
| if !value || | ||
| value == 0 || |
There was a problem hiding this comment.
Align the operands of a condition in an if statement spanning multiple lines.
Use value.zero? instead of value == 0.
cbrunsdon
force-pushed
the
early_config
branch
from
b80e4be to
9abe73a
Compare
Nothing in preferences needs to be in /app, as nothing relies on rails anymore
This allows apps to require spree/config earlier in their startup and access the configuration before its set by the rails environment.
Nothing in here requires rails to exist, so it can live in /lib just as easily as /app/models
With the previous commit I can now require this at the top
cbrunsdon
force-pushed
the
early_config
branch
2 times, most recently
from
1a0952c to
72cc52a
Compare
jhawthorn
changed the title
This reflects the current structure of the filesystem since that class' file has been moved from /app to /lib with solidusio#2178
This moves preferences out of /app into /lib, as nothing in here should require rails to run.
It also moves the initialization of the Spree::Config instance to be in the spree/config file, better allowing applications to control when this is available.