Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unhelpful preload in Stock::Estimator #2207

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Sep 7, 2017

These included records aren't being used by the taxation classes, which do their own querying.

The include was introduced by me in 17e8ea5, at the time the includes were used, but are no longer as of 2426c37.

These included records aren't being used by the taxation classes, which
do their own querying.
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@jhawthorn jhawthorn merged commit c62dabb into solidusio:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants