Some admin UI enhancements #2255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
several-admin-enhancements
branch
from
4e701b8 to
a000876
Compare
tvdeyen
force-pushed
the
several-admin-enhancements
branch
3 times, most recently
from
49d7513 to
a7e2eb0
Compare
tvdeyen
force-pushed
the
several-admin-enhancements
branch
3 times, most recently
from
01921a2 to
8597448
Compare
After going full house bootstrap the form looks a little off. This re-structures the form so it fits better into the admin interface.
All our backbone views live in the spree/backend/views folder. Also uses our Spree javascript object to store the instance instead of a global.
Instead of defining the model everytime we render the payment screen we define a model in the spree/backend/models folder and initialize that when we render the payments screen.
The amount needs a min-width in order to not be too small in narrow areas. One might not be able to see the value. The addon shoud not have a fixed width, but a min-width so it grows when necessary, but not take too much space it actually does not need.
We sometimes want to vertically align table rows to the middle, not to the top as we do by default now. This new class allows to do so.
It is ok to just call this state "State" instead of "Payment State". We use this attribute in lots of tables and the space is limited.
The order payments table has lots of information and lacks some structure. By moving the amount to the right of the table and give it some as well as align it to the right this important piece of information is now better visible. If a user wants to change the amount of an uncaptured payment the form is now right by the action icons and not somewhere in the middle. By further shorten the creation date format we gain some valuable extra space.
All our backbone views now live in the spree/backend/views folder.
All our backbone models belong into the spree/backend/models folder.
When editing this row we diaply an input field. With our default top alignment of table rows this leads to jumpy UI.
These rows have input fields if editable and therefore look much better if vertically aligned to the middle instead of our default (top aligned)
It makes no sense to create a zero quantity line item.
In some rare circumstances the select2 dropdown opens above not below. As select2 is overly specific with this styles we need to overwrite these with our theme as well. This also fixes some border-radius issue we had.
tvdeyen
force-pushed
the
several-admin-enhancements
branch
from
8597448 to
ed1d987
Compare
|
Will split into several smaller PRs |
This was referenced Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of small fixes I collected while working on several other PRs.
This is best reviewed commit by commit.
If it is preferred to open separate PRs for some of this changes I am happily willing to do so.
Screens
Select2 Dropdown opened above instead of below
Before
After
Variant auto complete
Before
After
Credit card based payment methods form
Before
After