Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create multiple page states for stock transfers #2263

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Create multiple page states for stock transfers #2263

merged 1 commit into from
Oct 4, 2017

Conversation

jhawthorn
Copy link
Contributor

Rebase and modifications to #1963

@jhawthorn jhawthorn mentioned this pull request Oct 4, 2017
Closed
@jhawthorn
Copy link
Contributor Author

jhawthorn commented Oct 4, 2017 •
edited
Loading

Modifications made from #1963:

  • Stock transfer table should be shown if there are >= 2 stock locations. Not just > 0
  • Filters/search should always be shown, regardless of number of stock transfers
  • Updated to use new pill component

gmacdougall
gmacdougall approved these changes Oct 4, 2017
View reviewed changes
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. It's a rough area of the system and hopefully this make it a bit easier to use.

👍

@jhawthorn jhawthorn force-pushed the jtapia-stock-transfer-ui-changes branch from bf9e219 to bc74c29 Compare October 4, 2017 21:35
@jhawthorn jhawthorn merged commit 1a59cf8 into solidusio:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @gmacdougall