Fix restocking and unstocking backordered items in FulfilmentChanger #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some specs was incorrectly passing since they are not taking into account setting coherent value of the stock item's count on hand. If the shipment has 6 `backordered` inventory unit the related stock item must have at least -6 in the count on hand.
All inventory units which are not shipped can be restocked. Even backordered inventory units can be restocked.
If the stock item is backorderable unstock all quantity, else unstock only the max available quantity in the stock item
|
I don't think stock item's should have a negative count on hand. In my understanding, backordered stock items don't affect the count on hand. |
Desired stock item's count on hand could even be negative. If this happens availability should be considered 0.
DanielePalombo
force-pushed
the
nebulab/fix-stock-item-fulfilment-changer
branch
from
57f6d99 to
10499d3
Compare
|
I was wrong, just re-checked the way |
mamhoff
approved these changes
Oct 17, 2017
kennyadsl
approved these changes
Oct 17, 2017
There was a problem hiding this comment.
I talked with @DanielePalombo in real life about this issue as well and everything done here seems to make sense to me. 👍
jhawthorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues described in #2285.
Current code is not taking into account some important scenarios, like: