Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation for Adjustment Label #2287

Merged
merged 2 commits into from
Oct 26, 2017

Conversation

gregdaynes
Copy link

Updating the translation to reflect what the attribute is called to correct the error message when providing attributes to create. Spree::Adjustment.create! requires a description with message
'Description can't be blank', providing it using description: 'string' outputs "unknown attribute 'description' for Spree::Adjustment."

Updating the translation to reflect what the attribute is called to
correct the error message when providing attributes to create.
`Spree::Adjustment.create!` requires a description with message
'Description can't be blank', providing it using
`description: 'string'` outputs "unknown attribute 'description' for
Spree::Adjustment."
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unfortunately the specs expect the old translation

@gregdaynes
Copy link
Author

Tests have been fixed to account for new translations - Sorry, I should have commented earlier.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jhawthorn jhawthorn merged commit c27eb7b into solidusio:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants