Require only part of activemerchant #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrunsdon
reviewed
Oct 23, 2017
|
|
|
@mamhoff please rebase now that the factory bot rename is merged |
tvdeyen
approved these changes
Oct 25, 2017
jhawthorn
suggested changes
Oct 26, 2017
sample/spec/spec_helper.rb
Outdated
| @@ -12,6 +12,7 @@ | |||
| require 'rspec/rails' | |||
| require 'ffaker' | |||
| require 'spree_sample' | |||
| require 'factory_girl' | |||
There was a problem hiding this comment.
This will generate a warning and I don't think it is necessary after a rebase (the Gemfile will cause factory_bot to be required).
It turns out we also don't need factories at all for this test suite, so I have removed them in #2330
ActiveMerchant comes with a large list of glue code for gateways and more things that is not needed for many Solidus stores. This replaces requiring all of ActiveMerchant with just those files/classes we need.
Versions before that do not work with Rails 5, upon which we depend. With recent work on explicitly requiring only those bits of ActiveMerchant that we need, I needed to test the full range of ActiveMerchant versions for compatibility in their gem structure. That task can only be started at the first version our gem actually bundles with.
jhawthorn
force-pushed
the
require-only-part-of-activemerchant
branch
from
b0b7305 to
b3fb4c2
Compare
|
rebased and removed (now unnecessary) last commit |
jhawthorn
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveMerchant is 2.5 megs of glue code that we don't need. This PR only requires those files of ActiveMerchant that we do need: Errors, Billing Response and Credit Card.
It also bumps the required ActiveMerchant Version to 1.66, as that is the first version that works with Rails 5.1.