Fix module/class nesting in calculator/* #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 23, 2017
| max = preferred_max_items.to_i | ||
| quantity.times do |i| | ||
| # check max value to avoid divide by 0 errors | ||
| if (max == 0 && i == 0) || (max > 0) && (i % max == 0) |
There was a problem hiding this comment.
Use max.zero? instead of max == 0.
Use i.zero? instead of i == 0.
Use (i % max).zero? instead of i % max == 0.
|
|
||
| return BigDecimal.new(0) if items_count == 0 | ||
| return BigDecimal.new(0) if items_count == 0 |
There was a problem hiding this comment.
Use items_count.zero? instead of items_count == 0.
cbrunsdon
force-pushed
the
fix_calculator_definitions
branch
from
2e244fa to
dfbf5d5
Compare
4 tasks
jhawthorn
reviewed
Oct 23, 2017
| @@ -1,58 +1,60 @@ | |||
| require_dependency 'spree/calculator' | |||
There was a problem hiding this comment.
Shouldn't this require make the change unnecessary?
There was a problem hiding this comment.
Its not require_dependency'd everywhere its defined/used.
I'd say we fix the definitions to be consistent and not have to worry about it.
tvdeyen
reviewed
Oct 25, 2017
|
Okay, I don't personally agree with the require_dependency over keeping the class definitions the same, but I'll switch it. Are we okay with me leaving them broken out so its clear Calculator is a class and not a module? |
Since our class declarations are so busted, we need to ensure this is lodaed first.
cbrunsdon
force-pushed
the
fix_calculator_definitions
branch
from
dfbf5d5 to
8215101
Compare
jhawthorn
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spree::Calculator is a class (that inherits from Spree::Base), but in
these definitions we don't clarify it as such.