Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed caching of taxon menu. #2317

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fixed caching of taxon menu. #2317

merged 1 commit into from
Oct 26, 2017

Conversation

bofrede
Copy link
Contributor

@bofrede bofrede commented Oct 23, 2017

The caching key have to include the selected taxon. This becomes apparent once the styling of pull request #2316 is merged.

cbrunsdon
cbrunsdon approved these changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks

gmacdougall
gmacdougall approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks for the contribution

@gmacdougall gmacdougall merged commit 46bb2d7 into solidusio:master Oct 26, 2017
@cedum cedum mentioned this pull request May 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

@cbrunsdon cbrunsdon cbrunsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bofrede @cbrunsdon @gmacdougall