Move Paperclip into an extension #2328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 25, 2017
| # This provides a more robust interface | ||
| # | ||
| # @return [Enumberable] of media for a variant | ||
| def gallery |
There was a problem hiding this comment.
Use empty lines between method definitions.
core/app/models/spree/product.rb
Outdated
| @@ -280,6 +266,16 @@ def find_variant_property_rule(option_value_ids) | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
houndci-bot
reviewed
Oct 25, 2017
| # This provides a more robust interface | ||
| # | ||
| # @return [Enumberable] of media for a variant | ||
| def gallery |
There was a problem hiding this comment.
Use empty lines between method definitions.
core/app/models/spree/product.rb
Outdated
| @@ -280,6 +266,16 @@ def find_variant_property_rule(option_value_ids) | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
swcraig
changed the title
This partial renders product images.
In the API.
In the API.
These are used mostly in the upload zone, progress, and related areas.
This has been moved to solidus_paperclip. Other image upload extensions will possibly need to borrow from there.
Extensions adding this would need to override this file.
Overrides have been added to the solidus_paperclip side.
Since we don't use Paperclip anymore, this isn't necessary.
This has been moved into the solidus_paperclip extension.
This also removes the code that loads the images.
We have taken all image (Paperclip) related content from Solidus.
TODO: This is hardcoded path right now. This needs to point to an actual gem before being merged.
Otherwise I would need to add a weird "guard" statement here, and I don't want to do that.
|
I think the best approach will be to merge #2337 before pulling out Paperclip. |
|
Can this move forward now? |
|
@swcraig there are a number of conflicting files but this is a great direction! |
Paperclip is dead and has been for months.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all Paperclip specific code (including all JavaScript related to uploading images in the admin) from Solidus. All of this functionality has been moved into a branch in (the currently temporary repo) solidus_paperclip.
Views in the admin/frontend render empty space for images. This way, future image uploading extensions only need to attach images to variants and they will show up in the expected places. Image upload implementations shouldn't need to know about specific views in Solidus.
This PR also adds
#gallerymethods toSpree::VariantandSpree::Product. These methods return an emptyEnumerable, which future image upload extensions would be expected to override. I can open a separate PR for this change, but it is cleaner to have#gallerybefore this is merged. Most notably for JBuilder endpoints in the API and also the Handlebars templates in the admin. By using the null object pattern here I can leave those files without modification for now.Spree::Taxon#iconhas been removed, and a decorator has been added on the extension side. If this needs a better interface, I will work on addressing that.This is a relatively large PR, and would be difficult to review easily. If there is an obvious way to split this up logically, please let me know.
I am more than happy to discuss any aspect of this change, and will do everything I can to move this forward in the best possible way.
Before this is merged solidus_paperclip needs to exist on solidusio-contrib and that location needs to be referenced in
lib/sandbox.sh. At the moment it's a hardcoded relative path on my machine.