Admin address fixes and extra address validation #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… states If you had a country without states + a manually typed-in `state_name` and then switched to a country with states, the form would still submit the old state_name alongside the new state_id. This updates the js code to disable both state inputs (`state_name` and `state_id`) by default and then re-enable whichever one ended up being used. This is the same thing we were already doing for hiding & showing the inputs.
…o states The admin wasn't clearing `address.state_id` from the DB when you switched from a country with states to a country without states. You would then end up with an address with both `state_name` and `state_id`, and `state_text` would end up showing the old `state_id`. This happened because we have the complicated state_name + state_id situation with addresses, and we swap out one form input with another depending on the country. We needed to provide default hidden inputs for state_name and state_id with blank values.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Nov 30, 2017
Saving an address with a country without states, after saving an address that instead has states will raise a validation error, since we are not resetting the state. We always had this issue, it's just raising after solidusio#2371, which describe the same issue but for backend. This commit fixes this problem by adding hidden fields that reset state_id and/or state_name if they are disabled (via js).
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
May 3, 2018
Saving an address with a country without states, after saving an address that instead has states will raise a validation error, since we are not resetting the state. We always had this issue, it's just raising after solidusio#2371, which describe the same issue but for backend. This commit fixes this problem by adding hidden fields that reset state_id and/or state_name if they are disabled (via js).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.
Admin:
state_idwasn't being cleared in some cases when changed via the admin.Core: Add an address validation to ensure that a state always matches the country if presence.