Extract stock transfers to solidus_stock_transfers extension #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
That is a good decision! Thanks! |
jhawthorn
force-pushed
the
remove_stock_transfers
branch
from
548c5e0 to
b80ab06
Compare
jhawthorn
added
changelog:solidus_backend
jhawthorn
force-pushed
the
remove_stock_transfers
branch
from
a26ca39 to
bfbcb51
Compare
jhawthorn
changed the title
cbrunsdon
approved these changes
Nov 22, 2017
kennyadsl
reviewed
Nov 22, 2017
This was only used by stock transfers
Now that stock transfers are gone, this only had one item.
jhawthorn
force-pushed
the
remove_stock_transfers
branch
from
f1c6d7b to
2d740f9
Compare
kennyadsl
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to extract stock transfers to a gem
(which I haven't done yet, therefore WIP)and here it is!This removes the stock transfers interface from the admin, extracting it to the new solidus_stock_transfers gem. This went really well! Nothing really referenced stock transfers, so it's quite a clean split.
Also extracted with this is the
NumberFieldcomponent, a JavaScript helper which was only ever used by stock transfers.