Promotions admin UI fixes #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
promotions-ui-fixes
branch
from
42577c7 to
894d79d
Compare
kennyadsl
approved these changes
Nov 25, 2017
mamhoff
approved these changes
Nov 25, 2017
tvdeyen
force-pushed
the
promotions-ui-fixes
branch
from
8aeaa5c to
af8427e
Compare
tvdeyen
added a commit
to tvdeyen/solidus
that referenced
this pull request
Dec 1, 2017
After the merge of solidusio#2394 the admin promotion adjustment spec that got introduced by solidusio#2400 broke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promotions UI has some smaller glitches. Mostly wrong padding and margins, due to the various layout changes we went through in the last couple of months.
Best reviewed commit by commit, pulled and ran in the local sandbox.
Before
After