Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require kaminari ~> 1.1 and some related improvements #2443

Merged
merged 3 commits into from
Dec 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/app/views/spree/api/shared/_pagination.json.jbuilder
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ json.count pagination.count
json.total_count pagination.total_count
json.current_page pagination.current_page
json.pages pagination.total_pages
json.per_page pagination.limit_value
json.per_page pagination.current_per_page
2 changes: 1 addition & 1 deletion api/solidus_api.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ Gem::Specification.new do |gem|
gem.add_dependency 'solidus_core', gem.version
gem.add_dependency 'responders'
gem.add_dependency 'jbuilder', '~> 2.6'
gem.add_dependency 'kaminari', '>= 0.17', '< 2.0'
gem.add_dependency 'kaminari-activerecord', '~> 1.1'
end
1 change: 1 addition & 0 deletions backend/lib/spree/backend.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
require 'font-awesome-rails'
require 'autoprefixer-rails'
require 'jbuilder'
require 'kaminari'

require 'spree_core'
require 'spree_api'
Expand Down
2 changes: 1 addition & 1 deletion backend/solidus_backend.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Gem::Specification.new do |s|
s.add_dependency 'jquery-rails'
s.add_dependency 'jquery-ui-rails', '~> 5.0.0'
s.add_dependency 'font-awesome-rails', '~> 4.0'
s.add_dependency 'kaminari', '>= 0.17', '< 2.0'
s.add_dependency 'kaminari', '~> 1.1'
s.add_dependency 'jbuilder', '~> 2.6'

s.add_dependency 'handlebars_assets', '~> 0.23'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
it "can page through the orders" do
get :index, params: { page: 2, per_page: 10 }
expect(assigns[:orders].offset_value).to eq(10)
expect(assigns[:orders].limit_value).to eq(10)
expect(assigns[:orders].current_per_page).to eq(10)
end
end

Expand Down
2 changes: 1 addition & 1 deletion core/lib/spree/core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'awesome_nested_set'
require 'cancan'
require 'friendly_id'
require 'kaminari'
require 'kaminari/activerecord'
require 'mail'
require 'monetize'
require 'paperclip'
Expand Down
2 changes: 1 addition & 1 deletion core/solidus_core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |s|
s.add_dependency 'carmen', '~> 1.1.0'
s.add_dependency 'cancancan', '~> 1.10'
s.add_dependency 'friendly_id', '~> 5.0'
s.add_dependency 'kaminari', '>= 0.17', '< 2.0'
s.add_dependency 'kaminari-activerecord', '~> 1.1'
s.add_dependency 'monetize', '~> 1.1'
s.add_dependency 'paperclip', ['>= 4.2', '< 6']
s.add_dependency 'paranoia', '~> 2.4'
Expand Down
1 change: 1 addition & 0 deletions frontend/lib/spree/frontend.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
require 'sass-rails'
require 'font-awesome-rails'
require 'responders'
require 'kaminari'

require 'solidus_core'
require 'solidus_api'
Expand Down
2 changes: 1 addition & 1 deletion frontend/solidus_frontend.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Gem::Specification.new do |s|
s.add_dependency 'sass-rails'
s.add_dependency 'font-awesome-rails', '~> 4.0'
s.add_dependency 'truncate_html', '~> 0.9', '>= 0.9.2'
s.add_dependency 'kaminari', '>= 0.17', '< 2.0'
s.add_dependency 'kaminari', '~> 1.1'

s.add_development_dependency 'capybara-accessible'
end