Preparations for Rails 5.2 #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 2, 2018 16:56
Rails 5.2 has removed the ability to pass a string as the :if argument. Fortunately, we didn't really need it here.
Rails 5.2 doesn't allow passing raw strings to order (to avoid accidentally allowing user-provided strings)
secret_token is deprecated in Rails 5.2
Rails 5.2 has deprecated calling arel methods through delegation on an AR scope.
jhawthorn
force-pushed
the
rails_5_2_pre
branch
from
585e0cb to
9522e79
Compare
gmacdougall
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to avoid warnings and errors on Rails 5.2