Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding meta_title to api json product response #2480

Merged
merged 1 commit into from
Feb 22, 2018
Merged

adding meta_title to api json product response #2480

merged 1 commit into from
Feb 22, 2018

Conversation

loicginoux
Copy link
Contributor

the api response for a product gives the meta_description and meta_keywords but not the meta_title. I don't see why this attribute should not be in the api response.

tvdeyen
tvdeyen approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jhawthorn jhawthorn merged commit e7e8c1d into solidusio:master Feb 22, 2018
@jhawthorn
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loicginoux @jhawthorn @tvdeyen @kennyadsl