Fix calculator class check bug #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pelargir, thank you! Would you mind adding a spec for the intended behaviour? I know there is one :) |
houndci-bot
reviewed
Jan 11, 2018
|
|
||
| describe '#calculator_type=' do | ||
| subject { Calculable.new } | ||
|
|
Using #is_a? to check the calculator class doesn't play well with calculators that are subclasses of each other. For example, given calculator A and calculator B, where B is a subclass of A: if a shipping method is configured to use calculator B, it becomes impossible to switch the shipping method to calculator A since A.is_a?(B) returns true. Whereas A.instance_of?(B) returns false. If the intention is to prevent the same calculator from being set twice, #instance_of? is the correct choice since it disregards subclasses and only returns true if both are the exact same class.
|
@mamhoff done! |
mamhoff
approved these changes
Jan 14, 2018
jhawthorn
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug found when attempting to change a shipping method's calculator to a different calculator that is a subclass of its current calculator. The existing implementation of this code prevents switching between calculators that subclass other calculators.
Using
#is_a?to check the calculator class doesn't play well with calculators that are subclasses of each other. For example, given calculator A and calculator B, where B is a subclass of A: if a shipping method is configured to use calculator B, it becomes impossible to switch the shipping method to calculator A sinceA.is_a?(B)returns true. WhereasA.instance_of?(B)returns false.If the intention is to prevent the same calculator from being set twice,
#instance_of?is the correct choice since it disregards subclasses and only returns true if both are the exact same class.