Use datalist instead of jquery-ui/autocomplete #2509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
jquery-ui/autocomplete
, which is only used in the product properties page, with the html5<datalist>
element.Browser support for datalist is patchy (notably no safari), but it is entirely fine for this page not to have autocompletion.
We had apparently already decided that the number of properties is few enough that they can be just dumped on the page as json. I'm keeping this assumption and just dumping them on the page as HTML.
Before
After (display will be browser and OS dependent)
See also #2469