Remove unused admin helpers #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes taxon_options_for and option_types_options_for, which haven't been used since 2012 (when their usage replaced with querying the API)
The only method defined here, show_not, hasn't been used since 2013.
The only page using this was removed from solidus 1.0.
The only method in here, sort_by_active_class, hasn't been used since 2012.
This hasn't been used since 2012, and was only ever used by other helper methods (probably why it was private, though that doesn't really restrict usage).
This hasn't been used since 2012, though an unused view which referenced it was around until recently. This method is badly named and is likely to confuse users. It looks like a route method with the "_path" suffix, but it has a different idea of what "path" means.
jhawthorn
force-pushed
the
remove_unused_helpers
branch
from
52caab5 to
639c657
Compare
mamhoff
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes several helpers from the admin which have not been used for a long time and I believe are unlikely to be used in extensions or stores.