Improve HTTP usage in update_positions #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were returning "Ok", but with Content-Type: text/javascript.
This endpoint doesn't take a product_id, so this URL doesn't generate correctly. It also is only ever requested as JS.
mamhoff
approved these changes
Jan 25, 2018
|
I've spotted an |
User error (mine)! Everything's good I had customized something else in my sandbox which was breaking this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some mildly bad HTTP behaviour that didn't really affect anything, but we might as well do it more properly.
Content-Type: text/javascriptwith a body of"Ok"."Ok"is not valid JSON 🚫OptionTypesController#update_values_positionshad an unusedformat.htmlresponse, which didn't work.dataType: 'script'(ie. get some javascript and eval it), which isn't actually what we wanted.