Introduce "suppliable" scope to represent any variant which can_supply?(1) #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacdougall
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when using the API to query variants, we could only restrict by variants which were
in_stock, which meant any variant which either does not track inventory or has acount_on_hand > 0.In the admin we were using the in_stock scope, which made it impossible to add out of stock but backorderable products to the cart, despite them being possible to add on the frontend (See #2522).
This PR creates a new "suppliable" scope, which returns all variants which are in stock, backorderable, or don't have their inventory tracked. It also adds support to the API variants route to query using this scope and changes to admin variant selectors to query this instead.
Fixes #2522