Convert trivial coffee to plain JS #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplifies. It doesn't need to be a class since it is never initialized.
|
Have you used any tool to perform this conversion? |
I used coffeescript (1.x version, since 2.0+ emits es6) and manually edited the output. |
kennyadsl
approved these changes
Feb 2, 2018
| Spree.ready(function() { | ||
| var $gateway_type = $('select.js-gateway-type'); | ||
| var $preference_source = $('select.js-preference-source'); | ||
| var original_gtwy_type = $gateway_type.val(); |
There was a problem hiding this comment.
what about taking advantage of this PR to change this variable name to original_gateway_type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts many of the remaining CoffeeScript files to plain JS.
This focuses on converting our remaining CoffeeScript files which can be straightforwardly converted to plain JS. These aren't huge files, are reasonably well organized already, and don't heavily use any of CoffeeScript's more powerful features (like classes).
This converts ~200 lines of CoffeeScript into ~280 lines of JS.
After this we are left with 250 lines of coffee in only a few sections, which I will tackle in separate PRs:
views/directory)