Refactor and convert Tabs component from CoffeeScript to JS #2549
+68
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had logic to see whether the container had grown or shrunk, and responded by either taking elements out of the dropdown or moving them in.
Instead, this commit combines the separate code paths and every time the width is changed removes all elements from the DOM and one-by-one re-inserts them into the correct parent.
This shouldn't be significantly slower then the previous behaviour because we are looking at very few DOM nodes and are careful to not force layout at any point in the loop.
We also convert Tabs from CoffeeScript to plain JS, as well as use the DOM directly instead instead of jQuery.