Generate correct number of codes in BatchBuilder #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was building codes on the association and then relying on the autosave behaviour to save the new records when save was called on the Promotion. It's simpler to just explicitly create them.
jhawthorn
force-pushed
the
promotion_batch_fix_2577
branch
from
2a461bf to
a969ef8
Compare
jhawthorn
changed the title
Previously, due to a bug in the inner loop, BatchBuilder could generate more codes than were requested. This removes the inner loop in favour of a single, smarter outer loop. Instead of always creating exactly batch_size new codes, we now create up to batch_size new codes. On each loop we try to generate batch_size new potential codes and only save the ones which are unique. This should result in fewer selects in scenarios where there is contention over codes. Though this is entire system is not well suited for there to be many conflicts.
jhawthorn
force-pushed
the
promotion_batch_fix_2577
branch
from
a969ef8 to
c905158
Compare
This was referenced Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to a bug in the inner loop,
BatchBuildercould generate more codes than were requested.This removes the inner loop in favour of a single, smarter outer loop. Instead of always creating exactly
batch_sizenew codes, we now create up tobatch_sizenew codes. On each loop we try to generatebatch_sizenew potential codes and only save the ones which are unique.This should result in fewer selects in scenarios where there is contention over codes. Though this is entire system is not well suited for there to be many conflicts.
Fixes #2577