Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use solidus_auth_devise GitHub master for sandbox #2583

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Use solidus_auth_devise GitHub master for sandbox #2583

merged 1 commit into from
Feb 21, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 19, 2018 •
edited
Loading

We need at least the 2.1 gem release of solidus auth devise, because we dropped the deface dependency in Solidus 2.5.0.

Without this might break the sandbox (the build in demo app), if people have an older version of solidus auth devise installed.

@jhawthorn
Copy link
Contributor

The current stable gem release of solidus auth devise fails with
current solidus core master, because we dropped the deface dependency.

This shouldn't be the case. Version 2.1.0 is the same as current master

@tvdeyen
Copy link
Member Author

tvdeyen commented Feb 19, 2018

Somehow this is now working for me. 🤔

I guess because I had solidus_auth_devise 2.0 installed it fulfilled bundlers needs, but failed because we do not have deface installed anymore. Now that I have solidus_auth_devise 2.1 installed it works like expected.

We should consider to add >= 2.1 to the sandbox's Gemfile

wdyt @jhawthorn ?

@tvdeyen
Use solidus_auth_devise >= 2.1 for sandbox
14e3876 
We need at least the 2.1 gem release of solidus auth devise,
because we dropped the deface dependency in Solidus 2.5.0.

Without this might break the sandbox (the build in demo app),
if people have an older version of solidus auth devise installed.
@tvdeyen tvdeyen force-pushed the sandbox-auth-master branch from cf870a5 to 14e3876 Compare February 19, 2018 19:55
@tvdeyen tvdeyen requested a review from jhawthorn February 19, 2018 19:57
jhawthorn
jhawthorn approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually perfectly happy to use the github release. Just wanted to make sure we weren't missing an issue in the latest release.

@gmacdougall gmacdougall merged commit b3f1d12 into solidusio:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvdeyen @jhawthorn @gmacdougall