Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render shipment json when payment source is nil #2611

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

loicginoux
Copy link
Contributor

When using a payment by check, the payment source is nil.
This cause the json rendering of a shipment to fails because it expects a payment.source to always be present.

Verified

This commit was signed with the committer’s verified signature.
kennyadsl Alberto Vena
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jhawthorn jhawthorn merged commit 2a95826 into solidusio:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants