Fix API url when editing image alt text in admin #2625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you upload a product image in BO, you can update the alternative text and save the change.
When doing this the url generated is
/en/api/variants/<PRODUCT_SLUG>/images/4
This is not actually causing any bug on the default solidus behaviour because the variant is not used in
Spree::Api::ImagesController#update
but if we would like to use the variant via the methodSpree::Api::ImagesController#scope
for example, it would produce an error (this is the case in our app for example)Example of log when saving the image alternative text:
As you see from the log we could not find the variant via the product slug.
Replacing the path by
/en/api/products/<PRODUCT_SLUG>/images/4
should fix this issue.