Update Orders state machine doc removing confirmation_required text #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwil
suggested changes
Mar 28, 2018
guides/orders/order-state-machine.md
Outdated
| `true`. | ||
|
|
||
| The `payment` state is optional and it's only triggered if `payment_required?` | ||
| returns `true`. |
There was a problem hiding this comment.
We should add a newline after this paragraph to separate it from the paragraph below.
There was a problem hiding this comment.
Ok! I thought that since it's a single line it would be better to compact those paragraphs but here is your land, I will update shortly! 😄
|
@kennyadsl Thanks for the mention 👍 |
This feature has been removed here: solidusio@8c8c84c
kennyadsl
force-pushed
the
update-order-state-machine-docs
branch
from
0357dde to
8966d6f
Compare
jhawthorn
approved these changes
Mar 28, 2018
|
@benjaminwil do you think it's ok now? |
|
@kennyadsl Yes, thanks. 😊 |
benjaminwil
approved these changes
Mar 30, 2018
| - The `confirm` state is only triggered if `confirmation_required?` returns | ||
| `true`. | ||
| The `payment` state is optional and it's only triggered if `payment_required?` | ||
| returns `true`. |
There was a problem hiding this comment.
I agree, we could have alternatively merged the paragraphs. But they are about different states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been removed here:
8c8c84c
cc @benjaminwil