Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale selector to frontend nav bar #2683

Merged
merged 1 commit into from
May 3, 2018

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Apr 6, 2018

This adds a locale selector to the frontend, a feature previously only available in solidus_i18n

My main concern with this PR is that it looks pretty dumb if we have both this selector and the locale selector from solidus_i18n (which I intend to remove for a 2.0 version)

@jhawthorn jhawthorn mentioned this pull request Apr 6, 2018
4 tasks
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We could just not render the partial until a new solidus_i18n version got released. But this is also fine.

@jhawthorn jhawthorn merged commit 2492b6e into solidusio:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants