Remove order-dependency from locale specs #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 9, 2018
| @@ -10,6 +10,7 @@ | |||
| end | |||
|
|
|||
| after do | |||
| I18n.locale = :en #reset locale after each spec. | |||
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
gevann
force-pushed
the
fixup-order-dependent-specs
branch
from
7f135cc to
73c982e
Compare
This commit removes an implicit order dependency in the frontend locale specs.
gevann
force-pushed
the
fixup-order-dependent-specs
branch
from
73c982e to
7d9f131
Compare
gmacdougall
approved these changes
Apr 10, 2018
jhawthorn
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
I'm okay with this, but it seems a little odd here given that nothing here changes the I18n.locale. I this the mistake here is arguably in controller_helpers_spec, which shouldn't test I18n.locale before making a request.
It might even make more sense in the spec_helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
bundle exec rspec --seed 13070 --format documentationwould fail in the front-end app due to test ordering. This PR removes this order dependency.