Remove assert_written_to_cache #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These weren't accessible and served no purpose
This is error prone and breaks in Rails 5.2, since the key being logged is an array. The key we see from AS::Notifications is now an array and has additional hashes on the template names (I assume russian doll caching related). It's too hard to predict where these values come from, so we can't continue testing this. We should have most of the benefit and testing of this by just counting the number of cache writes (which we were doing already).
tvdeyen
approved these changes
Apr 11, 2018
gmacdougall
approved these changes
Apr 11, 2018
|
I'd like to avoid removing even testing related methods in a SemVer minor release, but I think it's unlikely this is widely used, and it would break for everyone in Rails 5.2 regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is error prone and breaks in Rails 5.2, since the key being logged is an array.
The key we see from AS::Notifications is now an array and has additional hashes on the template names (I assume russian doll caching related). It's too hard to predict where these values come from, so we can't continue testing this.
We should have most of the benefit and testing of this by just counting the number of cache writes (which we were doing already).