Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uniq with distinct for cartons association #2710

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Replace uniq with distinct for cartons association #2710

merged 1 commit into from
Apr 26, 2018

Conversation

DanielePalombo
Copy link
Contributor

This PR is going to fix the issue #2653

Spree::Shipment#cartons should return a carton collection, to do this distinct is provided instead of uniq as scope parameter.

@DanielePalombo
Replace uniq with distinct for cartons association
b5cfc54 
Spree::Shipment#cartons should return a carton collection
@jhawthorn jhawthorn merged commit 675fd78 into solidusio:master Apr 26, 2018
@jhawthorn
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielePalombo @jhawthorn @gmacdougall