Recalculate order after reimbursement creation #2711
Conversation
| @@ -19,6 +19,7 @@ | |||
| let(:reimbursement) { Spree::Reimbursement.new(number: nil) } | |||
|
|
|||
| before do | |||
| allow(reimbursement).to receive(:recalculate_order) | |||
There was a problem hiding this comment.
why stubbing this method is needed?
There was a problem hiding this comment.
This method was stubbed because the reimbursement in this spec does not receive the order, so the reimbursement creation failed.
Now I'm going to check that order is provided before run recalculate on it.
| let(:customer_return) { create(:customer_return, line_items_count: 5) } | ||
|
|
||
| context "total is not assigned" do | ||
| before { expect(reimbursement).to receive(:calculated_total) { 100 } } |
There was a problem hiding this comment.
I'd move this expectation into the it block. It makes specs easier to read and we are not DRY anything here since it's just applied to a single spec.
|
|
||
| let(:reimbursement) { build(:reimbursement, order: customer_return.order) } | ||
|
|
||
| it "should assign total with the calculated_total result " do |
| before { expect(reimbursement).not_to receive(:calculated_total) } | ||
| let(:reimbursement) { build(:reimbursement, total: 10, order: customer_return.order) } | ||
|
|
||
| it "should not change the total value" do |
There was a problem hiding this comment.
should not change -> does not change
| expect(customer_return.order).to receive(:recalculate) | ||
|
|
||
| reimbursement.save | ||
| end |
There was a problem hiding this comment.
I'd remove the .after_create spec (it's a Rails responsibility to test it) in favor of a more high-level test that ensure that the order is properly recalculated after its creation.
DanielePalombo
force-pushed
the
nebulab/recalculate-order-after-reimbursement-creation
branch
3 times, most recently
from
b34b70e to
b5d7715
Compare
| @@ -18,6 +18,8 @@ class IncompleteReimbursementError < StandardError; end | |||
| accepts_nested_attributes_for :return_items, allow_destroy: true | |||
|
|
|||
| before_create :generate_number | |||
| before_create :calculate_total | |||
| after_create :recalculate_order | |||
There was a problem hiding this comment.
I am not sure if a AR hook is the best place to do that calculation (that may include API requests and other funky stuff shops do to determine the order totals). Maybe we should move this into the perform! method.
Calculate total before creation if total is not provided
After reimbursement creation run recalculate on order to recalculate the states of order.
DanielePalombo
force-pushed
the
nebulab/recalculate-order-after-reimbursement-creation
branch
from
b5d7715 to
f0a734b
Compare
|
Hi @tvdeyen, I moved the callback in the controller. What do you think about it now? |
|
Hey @DanielePalombo are you still working on getting this merged? |
|
Yes @jacobherrington, I'm waiting a response on it. |
This PR is going to fix the issue #2606
The issue happens because after reimbursement creation the order is not recalculated.
To fix it we run
order#recalculateinafter_createcallback, in this wayorder#payment_stateis updated to new state.