Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded admin store attributes #2713

Merged
merged 1 commit into from
May 1, 2018
Merged

Remove hardcoded admin store attributes #2713

merged 1 commit into from
May 1, 2018

Conversation

jtapia
Copy link
Contributor

@jtapia jtapia commented Apr 24, 2018

No description provided.

@jtapia jtapia changed the title Remove hardcoded store attributes Remove hardcoded admin store attributes Apr 24, 2018
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@@ -595,6 +595,7 @@ en:
spree/store:
one: Store
other: Stores
default: Default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in the activerecord.attributes section

@jtapia
Copy link
Contributor Author

jtapia commented Apr 25, 2018

@tvdeyen right, my bad, fixed

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Thanks

@kennyadsl kennyadsl merged commit d0badf0 into solidusio:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants