Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use two column layout for stock location form #2727

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Use two column layout for stock location form #2727

merged 1 commit into from
Sep 21, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 3, 2018

We have lots of vertical space, let's use it.

Before

localhost_3000_admin_stock_locations_1_edit laptop with hidpi screen 1

After

localhost_3000_admin_stock_locations_1_edit laptop with hidpi screen

@tvdeyen tvdeyen added UI changelog:solidus_backend Changes to the solidus_backend gem labels May 3, 2018
kennyadsl
kennyadsl approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better :)

gmacdougall
gmacdougall approved these changes Jun 29, 2018
View reviewed changes
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas!

@gmacdougall
Copy link
Member

@tvdeyen Would you be able to give this a rebase and merge it?

@tvdeyen
Use two column layout for stock location form
c9a3ecc 
We have lots of vertical space, let's use it.
@tvdeyen tvdeyen force-pushed the fix-stock-location-form branch from 0607320 to c9a3ecc Compare July 2, 2018 07:08
@tvdeyen
Copy link
Member Author

tvdeyen commented Jul 2, 2018

@gmacdougall sure. Done.

@tvdeyen tvdeyen merged commit dcc88cf into solidusio:master Sep 21, 2018
@tvdeyen tvdeyen deleted the fix-stock-location-form branch September 21, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@gmacdougall gmacdougall gmacdougall approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvdeyen @gmacdougall @kennyadsl