Round calculator values based on order currency #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Oct 2, 2018
|
|
||
| def compute(object) | ||
| computed_amount = (object.amount * preferred_flat_percent / 100).round(2) | ||
| currency_exponent = ::Money::Currency.find(preferred_currency).exponent |
There was a problem hiding this comment.
Shouldn't be the currency taken from the order where the calculator lives instead?
There was a problem hiding this comment.
Yeah, I like that better. I'll make the changes.
ericsaupe
force-pushed
the
order-currency-rounding
branch
from
98c0be6 to
4105e2d
Compare
|
@kennyadsl this is ready to be looked at again. Thanks! |
tvdeyen
approved these changes
Oct 12, 2018
ericsaupe
force-pushed
the
order-currency-rounding
branch
from
4105e2d to
c027685
Compare
Fixes solidusio#1957 by getting the exponent of the desired currency from Money::Currency
ericsaupe
force-pushed
the
order-currency-rounding
branch
from
c027685 to
0e08301
Compare
jacobherrington
approved these changes
Nov 22, 2018
|
Thanks @ericsaupe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1957 by getting the exponent of the desired currency from
Money::Currency