Move to sassc-rails #2883
Merged
Move to sassc-rails #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby Sass is deprecated and will be unmaintained. This commit moves Solidus to the recommended sassc-rails gem.
|
This is a WIP, but wanted to make sure this was the direction we should go. |
tvdeyen
approved these changes
Oct 2, 2018
backend/solidus_backend.gemspec
Outdated
| s.add_dependency 'sass-rails' | ||
| s.add_dependency 'sass', '>= 3.5.2' | ||
| s.add_dependency 'sassc-rails' | ||
| s.add_dependency 'sassc' |
There was a problem hiding this comment.
We should be fine with only depending on sassc-rails.
There was a problem hiding this comment.
Okay, thanks I will make that change and follow up by making sure the documentation is up to date with this change.
tvdeyen
approved these changes
Oct 3, 2018
kennyadsl
added a commit
to solidusio/solidus_gateway
that referenced
this pull request
Nov 3, 2018
They are useless and sass/rails break the build on master after solidusio/solidus#2883
kennyadsl
added a commit
to solidusio-contrib/solidus_editor
that referenced
this pull request
Nov 26, 2018
They are not needed and make test fail on solidus master now that sass/rails dependency has been removed with solidusio/solidus#2883
kennyadsl
added a commit
to solidusio-contrib/solidus_static_content
that referenced
this pull request
Nov 26, 2018
They are not needed and make test fail on solidus master now that sass/rails dependency has been removed with solidusio/solidus#2883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby Sass is deprecated and will be unmaintained. This commit
moves Solidus to the recommended sassc-rails gem.
Refs #2882