Use ActiveRecord relation for Spree::Shipment#line_items #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original plain ruby instance method has been replaced by an ActiveRecord `has_many` relation. This pure SQL solution should improve a bit performances and allow to add further relations using `has_many ... through: line_items`.
kennyadsl
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
Makes total sense, thanks!
Just for reference it was added here and I think it has been done not noticing that, transitioning from that complex method content that requires ruby to the simpler one, we could have moved that responsibility to ActiveRecord. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original plain ruby instance method has been replaced by an ActiveRecord
has_manyrelation. This pure SQL solution should improve a bit performancesand allow to add further relations using
has_many ... through: line_items.