Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors on admin shipment line item destroy failure #2892

Merged

Conversation

spaghetticode
Copy link
Member

In the admin area, when editing an order, if a line item for a shipment
cannot be destroyed for any reason then the proper message received via AJAX
must be shown to the user.

@spaghetticode spaghetticode force-pushed the admin_shipment_line_item_destroy_message branch from f31f90a to ad15a8c Compare October 4, 2018 21:31
In the admin area, when editing an order, if a line item for a shipment
cannot be destroyed for any reason then the proper message received via AJAX
must be shown to the user.
@spaghetticode spaghetticode force-pushed the admin_shipment_line_item_destroy_message branch from ad15a8c to 21a91bc Compare October 4, 2018 21:58
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spaghetticode !

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@kennyadsl kennyadsl merged commit fac5b35 into solidusio:master Oct 11, 2018
@kennyadsl kennyadsl deleted the admin_shipment_line_item_destroy_message branch October 11, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants