Fix tab selection in sidebar navigation #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 14, 2018
| visit spree.edit_admin_taxonomy_path(taxonomy) | ||
| only_one_selected_tab_inside?('[data-hook=admin_product_sub_tabs]', 'Taxonomies', spree.admin_taxonomies_path) | ||
| end | ||
|
|
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| @@ -40,4 +40,41 @@ | |||
|
|
|||
| expect(page).to have_current_path %r{/admin/taxonomies/\d+/taxons/\d+/edit} | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Layout/EmptyLines: Extra blank line detected.
bitberry-dev
force-pushed
the
bugfix/backend_fix_tab_selection_in_sidebar_navigation
branch
from
ab6c2a6 to
dd447b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
I noticed that two tabs was selected in sidebar navigation menu on taxon edit page (admin/taxonomy/:taxonomy_id/taxons/:id/edit)
I think only 'Taxonomies' tab should be selected
I added few tests and fixed it.