Fix deprecation warning for Spree::Shipment#reverse_chronological scope #2921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone! 👋
This is a small PR to fix a deprecation warning that shows up when running certain tests. The message goes like this:
From what I can see, the attributes used in here shouldn't generate any problems as they just store timestamps and the user is not passing any parameters to said query so SQL injection is unlikely.
Running the full test suite following this patch doesn't show the aforementioned warning anymore. This PR also future proofs this scope for an eventual Rails 6 update.
Let me know what you think!