Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to bypass SKU validation #2937

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Allow to bypass SKU validation #2937

merged 1 commit into from
Nov 20, 2018

Conversation

fastjames
Copy link
Contributor

Migrate the gate clause on validates_uniqueness_of :sku to a method,
so that implementors can override it.

@fastjames
Allow SKU validation to be overridden
10b2806 
Migrate the gate clause on `validates_uniqueness_of :sku` to a method,
so that implementors can override it.
kennyadsl
kennyadsl approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, thanks!

@tvdeyen tvdeyen changed the title Allow SKU validation to be overridden Allow to bypass SKU validation Nov 9, 2018
tvdeyen
tvdeyen approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would introduce a class that handles these validations, but this is ok for now and better than the current implementation.

@kennyadsl kennyadsl merged commit 27dc642 into solidusio:master Nov 20, 2018
@elia elia deleted the overridable_sku_validation branch December 17, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fastjames @tvdeyen @kennyadsl