Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the promotion rules implementation example #2954

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Expand the promotion rules implementation example #2954

merged 2 commits into from
Nov 27, 2018

Conversation

jacobherrington
Copy link
Contributor

I created a custom promotion rule for the first time today and had to piece some of this together. Hopefully it will help the next person :)

tvdeyen
tvdeyen approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

kennyadsl
kennyadsl approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobherrington jacobherrington merged commit 318ff36 into solidusio:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobherrington @tvdeyen @kennyadsl