-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add margin to billing fields #2985
Add margin to billing fields #2985
Conversation
Thanks @jacobherrington! Why the margin change to the button? |
@kennyadsl I noticed it later and didn't want to make a separate PR. The button is sitting at the very bottom of the page, it just adds a tiny amount of whitespace so that it's not against the bottom edge of the window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not address styling issues like this. More generic solutions are preferable. Otherwise the whole admin css getting more and more messier than it is already.
@tvdeyen I agree with your comments, this was sloppy CSS, but I do think we should have a presentable UI. As long as we have best practices CSS is fairly easy to overwrite. |
@tvdeyen I updated the selector for adding margin to the billing field. The UI change is the same, but this is much more specific to this single element. I looked for other places this CSS was needed and didn't find any, so I left the rules where they were. Please let me know if I need to do anything else for your approval. |
37ce137
to
83d8d68
Compare
@tvdeyen can you please review again? |
Really small, annoying style thing I noticed.
Before:
After: