Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seed file fully idempotent #3033

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

jontarg
Copy link
Contributor

@jontarg jontarg commented Jan 10, 2019

Description

Make zone members creation idempotent when running zones seed in order to avoid adding unnecessary records into the database each time the database is seeded.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thanks for the PR!

@jacobherrington jacobherrington merged commit e2ac66b into solidusio:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants