Add countries to state selection for zones #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
approved these changes
Jan 24, 2019
aitbw
reviewed
Jan 24, 2019
|
@jacobherrington 👍 but maybe we should squash commits? |
When editing a state based zone it is impossible to determine the country each state is in. For example, Maryland, Liberia and Maryland, USA are identical options. This is very confusing for the user and can lead to mishaps.
jacobherrington
force-pushed
the
add-countries-to-state-selection
branch
from
a45cb94 to
5d79d14
Compare
|
@kennyadsl done! |
kennyadsl
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds countries to the state selection when editing a zone.
This helps you keep from accidentally trying to ship things to Maryland, Liberia when you'd like to ship things to Maryland, USA. 😬
Checklist:
- [ ] Documentation/Readme have been updated accordingly- [ ] Changes are covered by tests (if possible)