Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Decorator documentation #3045

Conversation

jacobherrington
Copy link
Contributor

This change adds an example of using ActiveRecord inside a model
decorator. Largely adapted from a gist:
https://gist.github.com/kushniryb/101c161eab8d2d2e2e35e4a17b781d1b

This change adds an example of using ActiveRecord inside a model
decorator. Largely adapted from a gist:
https://gist.github.com/kushniryb/101c161eab8d2d2e2e35e4a17b781d1b
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but I'm super 👍 updating documentation since this is something asked often.

guides/source/developers/extensions/decorators.html.md Outdated Show resolved Hide resolved
guides/source/developers/extensions/decorators.html.md Outdated Show resolved Hide resolved
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobherrington !!!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️ 🚀 @jacobherrington thank you for your continuous improvement of Solidus docs!

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jacobherrington jacobherrington merged commit ae29800 into solidusio:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants