Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static attribute in store credit reason factory #3046

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Remove static attribute in store credit reason factory #3046

merged 1 commit into from
Jan 28, 2019

Conversation

kennyadsl
Copy link
Member

Description

We already converted the rest of the factories attributes to dynamic into #2831 but after merging that PR, we merged #2798 which was pretty old and was still using the old "way".

Checklist:

  • Pull Request guidelines are respected
  • Documentation/Readme have been updated accordingly
  • Changes are covered by tests (if possible)
  • Each commit has a meaningful message attached that described WHAT changed, and WHY

@kennyadsl
Remove static attribute in store credit reason factory
e22f1fe 
We already converted the rest of the factories attributes to dynamic
into solidusio#2831 but after merging that PR, we merged solidusio#2798 which was pretty
old and was still using the old "way".
@kennyadsl kennyadsl self-assigned this Jan 22, 2019
jacobherrington
jacobherrington approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

aitbw
aitbw approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

spaghetticode
spaghetticode approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kennyadsl kennyadsl merged commit 748e4b2 into solidusio:master Jan 28, 2019
@kennyadsl kennyadsl deleted the kennyadsl/factory-bot-dynamic-attrs branch January 28, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@aitbw aitbw aitbw approved these changes

@ericsaupe ericsaupe ericsaupe approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennyadsl @spaghetticode @ericsaupe @aitbw @jacobherrington