Fixing inventory unit finalizer #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Feb 11, 2019
There was a problem hiding this comment.
Thanks @seand7565 ! I'd love to see a regression test for this, this way we can be sure this does not happen again in the future.
seand7565
force-pushed
the
fix_stock_changes
branch
from
95eef4f to
1778328
Compare
|
Test added, all passing! |
kennyadsl
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Thanks @seand7565, I think this bugfix is very important, so I think it's a good idea to release 2.8.1 with this PR's code.
|
Thank @seand7565 to have fixed this bug. LGTM ! |
DanielePalombo
approved these changes
Feb 12, 2019
jacobherrington
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an order with more than one inventory_unit, the total of inventory_units in the shipment would be subtracted from the stock of each item. For example, if a customer ordered 5 of "Product A" and 3 of "Product B", both products would have their stock decreased by 8, because the code is summing the inventory_units in general, not the units specific to the line_item.