Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move misplaced end-user documentation #3104

Merged

Conversation

benjaminwil
Copy link
Contributor

@benjaminwil benjaminwil commented Feb 15, 2019

Description

Some of the end-users "Products" documentation was misplaced outside of the /guides/source directory. This commit just removes those (duplicated) documents.

It also adds the missing product properties documentation to the already-published "Product properties" article.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have added a CHANGELOG entry for this change (if needed)

Some of the end-users "Products" documentation was misplaced outside of
the `/guides/source` directory. This commit just removes those
(duplicated) documents. It also adds the missing product properties
documentation to the already-published "Product properties" article.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjaminwil 🎉

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjaminwil!

@kennyadsl kennyadsl merged commit 0520d8b into solidusio:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants